[FIX] Forum: Restore TinyMCE toolbar when editing posts with inline images

[mjansenDatabay]

Summary

Restore the forum TinyMCE toolbar when editing posts that contain drag-and-dropped inline images by disabling sticky toolbar docking and aligning image_advtab with the default editor profile.

Problem

After creating a forum post with an image inserted via drag-and-drop (without manually resizing it), reopening the post for editing often shows no RTE toolbar buttons. The editor content loads, but formatting controls are missing.

Mantis: https://mantis.ilias.de/view.php?id=47755

Root Cause

The forum uses a dedicated TinyMCE template (tpl.tinymce_frm_post.js) with toolbar_sticky: true. On long thread/edit pages, sticky docking can fade out the editor header (tox-editor-dock-fadeout, hidden visibility/opacity) while inline data: images are present in the saved HTML. This makes the toolbar appear broken after save/re-edit.

Solution

Remove toolbar_sticky from the forum TinyMCE profile so the toolbar stays attached to the editor instance on edit screens. Set image_advtab: false to match tpl.tinymce.js. This combination was verified locally (see internal evidence run advtab_no_sticky).

Alternatives considered: the full TinyMCE profile change from PR #11608 (paste_data_images: false, etc.) — deferred here to keep the fix minimal and address the visible toolbar regression directly.

Changes

• components/ILIAS/RTE/templates/default/tpl.tinymce_frm_post.js: remove toolbar_sticky; set image_advtab: false

Visual Evidence

Create Post (after drag & drop)

Before:

After:

Edit Existing Post

Before (toolbar missing):

After (toolbar visible):

Testing

Automated

• Unit tests added / updated
• Existing test suite passes locally
• Commands run:
  • bash ./scripts/PHPUnit/run_tests.sh
  • ./vendor/composer/vendor/phpunit/phpunit/phpunit -c ./components/ILIAS/Forum/phpunit.xml
  • ./vendor/composer/vendor/phpunit/phpunit/phpunit components/ILIAS/RTE/tests/ilTinyMCETest.php --bootstrap components/ILIAS/RTE/tests/bootstrap.php

Manual

• Forum: create post with drag-and-drop image (no resize) → save → edit → toolbar visible
• Forum: edit post with inline image on a long thread page → toolbar remains visible
• Question pool / other contexts using tpl.tinymce.js → unchanged

Assisted-by: Cursor AI