fix: CIビルドにADMOB_BANNER_AD_UNIT_IDをdart-defineで注入する - #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題
--dart-define=ADMOB_BANNER_AD_UNIT_IDが両ワークフローに渡されていなかった。String.fromEnvironmentはビルド時定数のため、CI環境変数があっても渡さないと届かない。結果として全配信済みバージョンでテスト広告ID（
ca-app-pub-3940256099942544/6300978111）が使われていた。修正
ios-release/android-release両ワークフローのビルドコマンドに追加：Codemagicダッシュボードで必要な作業
ios_signingグループにADMOB_BANNER_AD_UNIT_ID= iOSのバナー広告ユニットID を追加google_play_credentialsグループにADMOB_BANNER_AD_UNIT_ID= AndroidのバナーID を追加AdMobダッシュボード → アプリ → 広告ユニット で各プラットフォームのIDを確認。