fix: MainScreenのリスナー登録順序とTabController初期同期を修正 - #218
Merged
Conversation
- addListenerをsetAuthProviderより先に登録し、同期通知の取りこぼしを防ぐ - setAuthProvider後に_onDataProviderChanged()を即時呼び出し、データロード済み時のTabController長さを同期 - onSettingsReturnedで取り消し線設定をリロード
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容
addListenerをsetAuthProviderより先に登録し、同期通知の取りこぼしを防ぐsetAuthProvider後に_onDataProviderChanged()を即時呼び出し、データロード済み時のTabController長さを同期onSettingsReturnedで取り消し線設定をリロード背景
setAuthProvider内部で同期的にリスナーへ通知が飛ぶケースがあり、リスナー登録前に通知が来ると取りこぼしが発生していた。テスト