fix: ListItemEditDialogの保存時に自動購入済みロジックを追加 - #217
Merged
Conversation
UI改修で新設したListItemEditDialogに、既存ItemEditDialogにあった 「金額入力時の自動購入済み」ロジックが欠落していたバグを修正。 保存時にSettingsPersistence.loadAutoComplete()を読み、 price>0かつ未チェックの場合にisChecked:trueをセットする。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
c45312c6）で新設したListItemEditDialogに、詳細設定の「金額入力時の自動購入済み」機能のロジックが欠落していたバグを修正。ItemEditDialog._handleSave()にはあったロジックが、新ダイアログへのコピー時に抜け落ちていた。原因
ListItemEditDialogの保存ボタンがインライン同期クロージャで実装されており、SettingsPersistence.loadAutoComplete()を一切呼ばずにcopyWithでisCheckedを更新しないまま保存していた。修正内容
_handleSave()async メソッドを追加loadAutoComplete()を読み、price > 0 && !isCheckedの条件を満たす場合にisChecked: trueをセットテスト計画
flutter analyzeエラー0flutter test全512件パス（新規4件含む）🤖 Generated with Claude Code