Fix non-MPI build: guard domain_mgr_ getDomain() call#18
Open
gavdoubleu wants to merge 7 commits into
Open
Conversation
Reproducible conda environment for building and running JUNE2. Includes cxx-compiler (GCC on Linux), cmake, hdf5, yaml-cpp, openmpi, Python test deps (h5py, numpy), and optional deps metis and gperftools.
Non-MPI builds only forward-declare DomainManager, so the unguarded domain_mgr_->getDomain() call fails to compile. Wrap in #ifdef USE_MPI, matching every other domain_mgr_ call site in this file. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domain_mgr_->getDomain()call inrunSlotTransmissionneeds fullDomainManagertype, but it's only forward-declared withoutUSE_MPI. Wrapped in#ifdef USE_MPI, matching every otherdomain_mgr_call site in the file.Suggestion
CI currently only builds with MPI. Add a serial (
-DUSE_MPI=OFF) compile job to the PR gate to catch this class of bug.Test plan
-DUSE_MPI=OFF -DUSE_METIS=OFF) on NCCctestpasses