FIX: improve missing ConcatFeatures error message#1428
Open
AmirhosseinHonardoust wants to merge 3 commits into
Open
FIX: improve missing ConcatFeatures error message#1428AmirhosseinHonardoust wants to merge 3 commits into
AmirhosseinHonardoust wants to merge 3 commits into
Conversation
Signed-off-by: Amir <88084572+AmirhosseinHonardoust@users.noreply.github.com>
Signed-off-by: Amir <88084572+AmirhosseinHonardoust@users.noreply.github.com>
Signed-off-by: Amir <88084572+AmirhosseinHonardoust@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #663.
This PR improves the schema validation error message for pipelines where the output of the & combinator is passed directly into an estimator.
When the actual input schema appears to contain multiple parallel outputs, the error message now suggests using ConcatFeatures.
It also adds a regression test for this case.
Tested locally with:
python -m pytest test\test_core_pipeline.py -k missing_concat_features_error_messageResult:
1 passed, 79 deselected.