Views on going#26
Open
DDRMin wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds new endpoints to fetch supplier product prices and retrieve suppliers for a given product, along with the corresponding URL updates.
- Added an API view get_supplier_product_prices in warehouse/views.py that aggregates supplier pricing with warehouse details.
- Added an API view get_suppliers_for_product in product/views.py to return supplier IDs by product.
- Updated product/urls.py with the new endpoint for fetching suppliers of a product.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| warehouse_managment/warehouse/views.py | New endpoint to retrieve supplier product prices with added warehouse details. |
| warehouse_managment/product/views.py | New endpoint to retrieve supplier IDs by product. |
| warehouse_managment/product/urls.py | Updated URL patterns to include the new supplier endpoint. |
| ) | ||
|
|
||
| summary.append({ | ||
| "product_name": sp.product.product_name, |
There was a problem hiding this comment.
The code assumes sp is a model instance by using sp.product, but supplier_products is constructed with .values(...), resulting in dictionaries. To fix this, either remove the .values() call or access dictionary keys appropriately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.