Dev#22
Open
dadamsretrorabbit wants to merge 363 commits into
Open
Conversation
FredJEhlers
approved these changes
Feb 12, 2019
ash-rabbit
requested changes
Feb 12, 2019
| public async Task Put(int id, [FromBody] ReadingsEntry value) | ||
| { | ||
| var old = await _db.Readings.FindAsync(id); | ||
| _db.Entry(old).CurrentValues.SetValues(value); |
Collaborator
There was a problem hiding this comment.
Quick question, are we going to have any error handling? I'm not asking for code change, maybe you can tell me what your plans are and with an exception of that I'll resolve this comment.
Collaborator
Author
There was a problem hiding this comment.
@ash-rabbit We will put error handling on this. Will let you know when it has been done.
| @@ -12,7 +12,6 @@ public class MonitorsEntry | |||
| public double Max_flow { get; set; } | |||
Collaborator
There was a problem hiding this comment.
Quick suggestion, we can rename Max_flow to MaxFlow. But many of you are naming your variables according to the database field name. If thats the case then its cool.
Collaborator
Author
There was a problem hiding this comment.
Yes this is the database field name.
Collaborator
There was a problem hiding this comment.
Sounds good, so this issue is sorted
Feature/tank level
…nto feature/EventHistory # Conflicts: # WaterLog_Backend/Procedures.cs
…nto feature/EventHistory # Conflicts: # UnitTesting/UnitTesting.csproj # WaterLog_Backend/Models/DatabaseContext.cs
…er27/WaterLog-Back-End into feature/usage_cost_endpoint # Conflicts: # UnitTesting/UnitTest1.cs # WaterLog_Backend/DataPoints.cs # WaterLog_Backend/Procedures.cs
…nto feature/usage_cost_endpoint # Conflicts: # UnitTesting/UnitTest1.cs # WaterLog_Backend/Migrations/DatabaseContextModelSnapshot.cs # WaterLog_Backend/Models/DatabaseContext.cs # WaterLog_Backend/Procedures.cs
Feature/event history
…nto feature/Map # Conflicts: # WaterLog_Backend/Models/DatabaseContext.cs
…nto feature/email_escalation # Conflicts: # WaterLog_Backend/Models/DatabaseContext.cs # WaterLog_Backend/Procedures.cs
Feature/email escalation
Feature/map
updated TankMonitorsEntry
…Back-End into alerts_filter # Conflicts: # WaterLog_Backend/Controllers/MonitorsController.cs
Updated the alerts filter endpoint
Fix/update email body
Update web.config
update daily wastage controller
…nto fix/update_filter_method # Conflicts: # WaterLog_Backend/Controllers/SegmentEventsController.cs
updated filter model and method
filter bug fix
tank filter bug fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.