Pr/multilevel mixed rw ro - #1
Merged
Merged
Conversation
MultiLevelStorage::check() started from ReadWrite and demoted the composite to ReadOnly as soon as any level reported ReadOnly. The server then wraps the whole storage in ReadOnlyStorage, so every cache write is refused before any write-error policy is consulted, including writes to writable levels and preprocessor cache updates. That inverts the documented semantics: MultiLevel.md promises that read-only levels are "automatically skipped during writes, regardless of write policy", and put() already implements exactly that per-level skipping. The practical fallout is that the documented read-only fallback topology (fast writable local disk in front of a read-only shared remote, e.g. SCCACHE_S3_RW_MODE=READ_ONLY or an azure SAS token without write permission) silently stops populating the local disk cache entirely. Aggregate in the other direction: the composite is writable when any level is writable, and read-only only when every level is read-only. The existing single-level read-only test still passes; new tests cover mixed chains in both orders and the all-read-only chain. Fixes mozilla#2773 Signed-off-by: Steven Noonan <steven@edera.dev>
Why? Make Huddly builds identifiable from the version output while keeping the package and binary names unchanged.
Keep the manifest and lockfile consistent so Huddly builds report the intended release version.
geir-t
force-pushed
the
pr/multilevel-mixed-rw-ro
branch
from
August 6, 2026 12:15
fd4ef74 to
abd9b57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes in mozilla#2778 to fix the local cache write issue
changes version to sccache-huddly
bumps to 0.17.1