Skip to content

chore: deprecate in favour of @hs-web-team/eslint-config-node - #53

Open
davidding wants to merge 1 commit into
mainfrom
feature/deprecate-in-favour-of-eslint-config-node
Open

chore: deprecate in favour of @hs-web-team/eslint-config-node#53
davidding wants to merge 1 commit into
mainfrom
feature/deprecate-in-favour-of-eslint-config-node

Conversation

@davidding

Copy link
Copy Markdown
Contributor

Summary of Changes 📋

@davidding
davidding force-pushed the feature/deprecate-in-favour-of-eslint-config-node branch from bcdb1a2 to 5259a5b Compare May 27, 2026 09:59
@davidding
davidding marked this pull request as ready for review May 27, 2026 09:59

@swatinigam swatinigam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi David, from what I understand, portal-53's Nx version (v19) cannot be upgraded. Since the Cypress version is tied to Nx, it's been stuck on Cypress v13 and can't be updated until Nx is upgraded too. Because of this, portal-53 will need to continue using this package rather than switching to eslint-config-node, which only supports Cypress v15 and above. So, not sure we should deprecate it. If it helps, I could look into adding support for cypress v13 in eslint-config-node in the future.
Please let me know if I am missing anything.

@davidding

davidding commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Hi David, from what I understand, portal-53's Nx version (v19) cannot be upgraded. Since the Cypress version is tied to Nx, it's been stuck on Cypress v13 and can't be updated until Nx is upgraded too. Because of this, portal-53 will need to continue using this package rather than switching to eslint-config-node, which only supports Cypress v15 and above. So, not sure we should deprecate it. If it helps, I could look into adding support for cypress v13 in eslint-config-node in the future. Please let me know if I am missing anything.

Hi @swatinigam. My understanding is that the portal-53 repo itself is being deprecated, so we won't be updating any dependencies in that project going forward, anyway - so it can continue to use the final version of this package?

@swatinigam

Copy link
Copy Markdown
Contributor

Hi David, from what I understand, portal-53's Nx version (v19) cannot be upgraded. Since the Cypress version is tied to Nx, it's been stuck on Cypress v13 and can't be updated until Nx is upgraded too. Because of this, portal-53 will need to continue using this package rather than switching to eslint-config-node, which only supports Cypress v15 and above. So, not sure we should deprecate it. If it helps, I could look into adding support for cypress v13 in eslint-config-node in the future. Please let me know if I am missing anything.

Hi @swatinigam. My understanding is that the portal-53 repo itself is being deprecated, so we won't be updating any dependencies in that project going forward, anyway - so it can continue to use the final version of this package?

Sounds fine to me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants