Droplist and current location added#2
Open
TomasJank wants to merge 2 commits into
Open
Conversation
rngadam
reviewed
Jan 4, 2019
| } | ||
| /* Toast.makeText(mContext, objectString, Toast.LENGTH_SHORT).show();*/ | ||
| br.close(); | ||
| } catch (IOException e) { |
Collaborator
There was a problem hiding this comment.
at least a printStackTrace here?
Ideally should wrap and rethrow in a custom exception so the UI can notify the frontend
rngadam
reviewed
Jan 4, 2019
| Toast.makeText(MainContext.INSTANCE.getContext(), "Saved", Toast.LENGTH_SHORT).show(); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); | ||
| Toast.makeText(context, "Not saved", Toast.LENGTH_SHORT).show(); |
Collaborator
There was a problem hiding this comment.
seems like your code is not properly layered, both doing I/O and interacting with the frontend. This makes your code hard to reuse and test
rngadam
reviewed
Jan 4, 2019
| String content = FileUtils.readFile(MainContext.INSTANCE.getResources(), R.raw.shanghai); | ||
| wiFiLocations = new JSONObject(content); | ||
| Toast.makeText(MainContext.INSTANCE.getContext(), "Loaded locations with " + wiFiLocations.length() + " MAC -> location mappings", Toast.LENGTH_LONG).show(); | ||
| } catch (Exception e) { |
Collaborator
There was a problem hiding this comment.
catchall exceptions are generally bad. you want to be specific
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a dropdown list for location selections and a textview for a current location