Skip to content

docs: replace workflow contract with overview diagrams - #110

Merged
Honguan merged 1 commit into
mainfrom
agent/docs-multi-agent-overview
Aug 3, 2026
Merged

docs: replace workflow contract with overview diagrams#110
Honguan merged 1 commit into
mainfrom
agent/docs-multi-agent-overview

Conversation

@Honguan

@Honguan Honguan commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the verbose bilingual Workflow contract section with the dedicated multi-agent workflow overview diagrams
  • rename the section to 多代理工作流程總覽 / Multi-Agent Workflow Overview
  • add language-specific image assets without changing the existing workflow-overview.png
  • update the README workflow test to validate the new section and image links

Validation

  • npm test (109 passed)
  • npm run check
  • npm run test:package

No issue number was specified for this change.

@Honguan
Honguan merged commit 3f7ae4b into main Aug 3, 2026
13 checks passed
@Honguan
Honguan deleted the agent/docs-multi-agent-overview branch August 3, 2026 13:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1f32fb9dbb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.en.md
### PLAN.md lifecycle

Each workflow uses only `<CODEX_ROOT>/model-router/workflows/<workflow_id>/PLAN.md`. Only the active writable executor writes atomically; reviewers do not write it. After `PASS`, the same owner removes the directory. Blocking, resume, replacement, and primary switches preserve path, version, and owner; cleanup failure is stored as `cleanup-failed`.
![Multi-Agent Workflow Overview](docs/images/en/multi-agent-workflow-overview-en.png)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use the contract's exact persisted state field names

The “Workflow State Fields” panel in both linked diagrams presents allowed_actions, execution_attempts, failure_class, and plan_hash as atomically persisted fields, but the declarative contract requires luna_allowed_actions, terra_execution_attempts, and rollback_class, and defines no plan_hash. Since this diagram replaces the textual contract, a host following it can persist incompatible state and lose action policy, retry counters, or rollback classification during recovery; regenerate the panel with the exact schema or clearly label these as non-schema examples.

Useful? React with 👍 / 👎.

Comment thread README.md
### PLAN.md 生命週期

每個 workflow 只使用 `<CODEX_ROOT>/model-router/workflows/<workflow_id>/PLAN.md`。只有 active writable executor 能原子寫入;reviewer 不寫檔。`PASS` 後由同一 owner 清理該目錄;阻塞、恢復、替換與 primary switch 保留 path、version、owner;清理失敗標記為 `cleanup-failed`。
![多代理工作流程總覽](docs/images/zh-TW/multi-agent-workflow-overview-zh-TW.png)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the second Terra execution attempt in the diagram

In both language-specific diagrams, a failure of the Stage 3 Terra-execute/Sol-review sequence goes directly to full takeover. The production transition table instead keeps the first failure in SOL_PLAN_REVIEW_WITH_TERRA, increments terra_execution_attempts, and permits a second Terra attempt; only the second failure starts SOL_FULL_TAKEOVER. A host implementing this replacement overview would therefore escalate one attempt too early, so the diagram needs a retry loop before the takeover arrow.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant