bundle/checker: enable typed: strict#22157
Merged
MikeMcQuaid merged 1 commit intoHomebrew:mainfrom May 7, 2026
Merged
Conversation
Contributor
Author
|
Hi @MikeMcQuaid I opened first PR for this repository. Could you please review this? Welcome to any feedback. Thanks |
Contributor
|
In case you were wondering, I think the docs job is failing because HTML-Proofer is getting 503s from existing Debian wiki links ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Bumps
Library/Homebrew/bundle/checker.rbfrom# typed: trueto# typed: strict. This finishes the directory-wide migration started in #21935, which leftchecker.rbandcommands/exec.rbas the only twotyped: truefiles remaining underLibrary/Homebrew/bundle/.To satisfy strict mode the change also:
sigblocks to the eight previously unsigneddef self.*methods (check,apps_to_install,formulae_to_start,taps_to_tap,casks_to_install,formulae_to_install,registered_extensions_to_install,reset!);@dslinstance variable asT.nilable(Homebrew::Bundle::Dsl)inreset!; andraise ArgumentError, "dsl is unset!" unless @dslbefore the three@dsl.entriesaccesses, mirroring the pattern already used inLibrary/Homebrew/bundle/commands/cleanup.rb.No new tests: there is no behaviour change on the happy path. The new guard converts one specific misuse (calling a private check method without first invoking
.check) from an opaqueNoMethodErroronnilinto an explicitArgumentError, matching the message used bycleanup.rb. The existingtest/bundle/commands/check_spec.rbcovers the public surface and continues to pass.Verified locally:
./bin/brew typecheck: No errors./bin/brew style --fix --changed: no offenses./bin/brew tests --only=bundle/commands/check: 20 examples, 0 failures