Skip to content

cask/cask: rescue with no method#21553

Merged
MikeMcQuaid merged 2 commits intomainfrom
fix-cask-matrix-generation
Feb 10, 2026
Merged

cask/cask: rescue with no method#21553
MikeMcQuaid merged 2 commits intomainfrom
fix-cask-matrix-generation

Conversation

@bevanjkay
Copy link
Copy Markdown
Member

@bevanjkay bevanjkay commented Feb 10, 2026

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

I used claude-code to help debug the issue.


As discovered in https://github.com/Homebrew/homebrew-cask/actions/runs/21855449950/job/63071483158?pr=248614 there are instances where the version can be invalid on a specific architecture, in this case the generation fails for the Linux map because the version is only referenced in on_{os} blocks, and the url is at the top-level. This should catch the error and skip for the architectures that are invalid.

This comment was marked as outdated.

@bevanjkay bevanjkay marked this pull request as draft February 10, 2026 07:47

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@bevanjkay bevanjkay marked this pull request as ready for review February 10, 2026 08:14
@bevanjkay bevanjkay requested a review from Copilot February 10, 2026 08:14
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/test/cask/cask_spec.rb
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit 5457825 Feb 10, 2026
81 of 83 checks passed
@MikeMcQuaid MikeMcQuaid deleted the fix-cask-matrix-generation branch February 10, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants