Show git branch in default footer#2347
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the GitBranch status item to the default TUI footer configuration. It also updates the test suite to disable GPG signing for test git commits, asserts that the default footer contains the new GitBranch item, and adds a test verifying that the workspace branch is correctly rendered in the default footer. There are no review comments, and I have no additional feedback to provide.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56d2e74b0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Ready for review now. Follow-up commit 834bfeb addresses the Codex P2 feedback by reading the cached workspace context instead of running git from footer rendering. All CI checks are passing, including Windows, and the inline review thread has a direct fix reply. |
|
oooh thank you. let me think about how to fit this without overwhelming the ui/ux. I think there might be a way to get this on the sidebar |
Summary
/statusline.Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featurescargo test -p codewhale-tui --bin codewhale-tui --all-features default_footercargo test -p codewhale-tui --bin codewhale-tui --all-features render_footer_from_git_branch_item_renders_workspace_branchChecklist
Closes #2341