fix(tools): raise tool search default results#2344
Open
nightt5879 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable max_results parameter to the tool search functionalities (both regex and BM25-like search), replacing the previous hardcoded limit of 5. The tool schemas are updated to expose this parameter with a default of 20 and a maximum limit of 100, and comprehensive unit tests are added to verify this behavior. There are no review comments, so I have no feedback to provide.
Contributor
Author
|
Ready for review now. All GitHub Actions checks are green, including macOS and Windows test jobs. I also checked the AI reviews: Gemini reported no review comments, Greptile passed, and there are no unresolved review threads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_resultsparameter to both tool-search schemas with default20and cap100.Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featurescargo test -p codewhale-tui --bin codewhale-tui --all-features tool_search_Checklist
Closes #2339