Fix MMOITems lore duplication issue#278
Merged
Merged
Conversation
Kqliber
approved these changes
May 22, 2026
Kqliber
left a comment
Kqliber
left a comment
Member
There was a problem hiding this comment.
this needs to be tested on folia at some point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277
This fixes 2 issues:
[refresh]or menu reopen.The first issue was caused because the items were not always cloned.
The second issue was caused because command registration was delayed using a scheduler. This issue was added with Folia support. In case menu registration starts to fail on Folia now, we may need to schedule the registration but only when the server is Folia.
Tested by a person in discord: https://discord.com/channels/164280494874165248/1381994944960401501