Skip to content

feat: implement oss-dev doctor command with full diagnostics#49

Open
geetanunakani wants to merge 1 commit into
Hell1213:mainfrom
geetanunakani:feature/doctor-command
Open

feat: implement oss-dev doctor command with full diagnostics#49
geetanunakani wants to merge 1 commit into
Hell1213:mainfrom
geetanunakani:feature/doctor-command

Conversation

@geetanunakani

@geetanunakani geetanunakani commented May 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Implemented oss-dev doctor command with full system diagnostics

Related Issue

Fixes #36

Type of Change

  • Bug fix
  • New feature
  • Documentation
  • Refactoring
  • Test changes
  • CI/Chore

Testing

  • uv run ruff check passes
  • uv run mypy passes
  • uv run pytest passes
  • Manual testing done

Description

Fixes #36

Changes Made

  • Implemented oss-dev doctor command with full system diagnostics
  • Checks Python version (3.10+)
  • Checks git CLI installation
  • Checks gh CLI installation and authentication
  • Checks config file existence
  • Checks GEMINI_API_KEY and GITHUB_TOKEN environment variables
  • Reports results with pass/warn/fail status using Rich library

Skills Used

  • Python, Rich library, Click CLI

@Hell1213 Hell1213 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: doctor command

Hi @geetanunakani, the doctor command is useful and works well. Tests pass (72/72).

Minor style issue: The function has inline imports (import os, import sys, import shutil) inside the function body. The codebase convention is to put all imports at the top of the file. Please move these to the top of cli/oss_commands.py.

Also, add a blank line before the @oss_dev_group.command decorator for readability.

Other than that, the diagnostics look comprehensive and the Rich output is nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement oss-dev doctor command with full diagnostics

2 participants