perf(rls): wrap auth.uid()/current_setting() in (select …) for per-statement evaluation#5705
Open
dmitrymaranik wants to merge 1 commit into
Open
perf(rls): wrap auth.uid()/current_setting() in (select …) for per-statement evaluation#5705dmitrymaranik wants to merge 1 commit into
dmitrymaranik wants to merge 1 commit into
Conversation
|
@dmitrymaranik is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres re-evaluates a bare
auth.uid()/current_setting(…)in an RLS policy once per row. Wrapping it in a scalar subquery —(select auth.uid())— makes it an InitPlan the planner evaluates once per statement and caches. It's predicate-equivalent (row visibility unchanged) and the optimization Supabase documents for RLS.This adds a migration that wraps the 7 affected per-user policies:
USINGandWITH CHECK(the write path runs per inserted/updated row too).pgrls fix --rule PERF001output, added as a new migration (20260629150153_wrap_rls_perf_initplan.sql).Happy to adjust the migration filename/placement to your conventions.