Simplify default specification and remove unused code#238
Open
Bisaloo wants to merge 3 commits into
Open
Conversation
HelenaLC
reviewed
Jun 6, 2026
Bisaloo
commented
Jun 6, 2026
| stopifnot(length(value) %in% c(1, ncol(x))) | ||
| stopifnot(all(nchar(value) > 0, na.rm=TRUE)) | ||
| if (is.null(rk <- region_key(x))) region_key(x) <- "region" | ||
| rk <- region_key(x) <- region_key(x) %||% "region" |
Collaborator
Author
There was a problem hiding this comment.
With the change, rk is also set to "region" if region_key(x) was missing. This was not the case before but it looks like maybe a bug.
Owner
There was a problem hiding this comment.
Agreed. setReplaceMethod("regions" does this too: default to "region" is missing.
Owner
There was a problem hiding this comment.
Alright, it passed (but took 1.5h) :)) We gotta keep remotes: for now, however, until spatialdataR is updated regularly upstream. I am avoiding frequent updates to not confuse the reviewer.
Bisaloo
force-pushed
the
simplify-20260606
branch
from
6d29f28 to
2482505
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.