Skip to content

test: pin SQL surface for curate and document exactly one SELECT rule #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Prateekathub wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: pin SQL surface for curate and document exactly one SELECT rule #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77c1a97
test: pin SQL surface for curate and document exactly one SELECT rule
Prateekathub Aug 30, 2026
bb74ff7
fix: adjust describe and summarize tests to return exactly one row
Prateekathub Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CATALOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ hflow curate --sql-file query.sql \

Pass exactly one of the positional SQL string or `--sql-file`; passing both or
neither is an error.
The curate() function accepts exactly one SELECT statement

The manifest is written **manifest-last**: to a temp file, renamed into place
only after the query completed, so a partial manifest is unreachable.
Expand Down
15 changes: 15 additions & 0 deletions tests/test_catalog_curation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,6 +837,21 @@ def test_constrained_connection_confines_sql_to_the_catalog(tmp_path: Path) -> N
False,
id="legitimate-single-select",
),
pytest.param(
"PIVOT episodes ON status USING count(*)",
True,
id="pivot", # DuckDB secretly expands this to CREATE then SELECT
),
pytest.param(
"DESCRIBE SELECT episode_id FROM episodes",
False,
id="describe",
),
pytest.param(
"SUMMARIZE SELECT episode_id FROM episodes",
False,
id="summarize",
),
]


Expand Down
Loading