[cmake] Disallow undefined symbols in most ndlls - #323
Merged
Conversation
If a symbol is undefined, it may cause a load time error. We can catch this at link time instead by using --no-undefined. Some ndlls intentionally allow undefined symbols, so this is not applied universally.
tobil4sk
force-pushed
the
fix/no-undefined
branch
from
August 16, 2026 19:37
4734f5b to
7ec9052
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a symbol is undefined, it may cause a load time error. We can catch this at link time instead by using --no-undefined. Some ndlls intentionally allow undefined symbols, so this is not applied universally.
This helps avoid broken builds such as: https://gitlab.archlinux.org/archlinux/packaging/packages/neko/-/work_items/1