+ a fast tier on every working-branch push - #13
Conversation
A push only regenerated derived files; the first real feedback came from opening a pull request, which runs the whole matrix. That makes the expensive tier the thing people use to find out whether their code compiles, so it runs ten times per change instead of once. smoke.yml calls the shared dotnet-smoke.yml: one OS, fast tests only, no coverage, no package-README check, twenty-minute cap. A test is in that tier unless it says otherwise -- Slow, or one of the categories that are slow by nature, takes it out. Opting out defers a test rather than skipping it: the pull request still runs everything.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 006dc21446
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,20 @@ | |||
| name: Smoke | |||
There was a problem hiding this comment.
Adding this workflow changes the repository's CI behavior, but .github/workflows/README.md still omits smoke.yml from both its file inventory and pipeline diagram, despite claiming to describe everything in the folder. Contributors will therefore see an incorrect branch-push feedback path; update that workflow guide alongside this behavior change.
AGENTS.md reference: AGENTS.md:L31-L35
Useful? React with 👍 / 👎.
1 participant
A push to a working branch only regenerated derived files. The first real feedback came from opening a pull request, which runs the whole matrix — so the expensive tier became the thing people use to find out whether their code compiles, running ten times per change instead of once.
smoke.ymlcalls the shareddotnet-smoke.yml@v1: one OS, fast tests only, no coverage, no package-README check, twenty-minute cap.A test is in the fast tier unless it says otherwise —
[Category("Slow")], or one of the categories that are slow by nature (EndToEnd,OsIntegration,ExternalInterop,PolyglotInterop,Performance), takes it out. That direction, not the inverse: tagging every fast test would mean touching thousands and remembering each new one, and the one somebody forgets drops out silently.Opting out defers a test, it never skips one. The pull request still runs everything; the tiers decide when, not whether.
The convention and its rationale live in RepositoryTemplate
CONTRIBUTING.mdandAGENTS.md.