Fix .no_proxy() on wrong client, clarify naming and remove redundant state#1
Merged
Conversation
…state - Move .no_proxy() from the request-builder client (where it had no effect) to the slot clients in pool::build_client() where requests are actually executed. Previously HTTP_PROXY/HTTPS_PROXY env vars would silently proxy all upstream traffic. - Remove stored target_url from ProxyHandler; store pre-computed base_path string instead, eliminating redundant URL representation. - Rename rate_micro_per_ns to rate_per_sec — the field stores raw tokens-per-second, not microtokens-per-nanosecond.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.no_proxy()from the request-builder client (where it had zero effect) topool::build_client()where requests are actually executed. PreviouslyHTTP_PROXY/HTTPS_PROXYenv vars would silently route all upstream traffic through a proxy.target_url: UrlfromProxyHandler; replaced with pre-computedbase_path: Stringto eliminate redundant URL representation (target_url,target_base, andhost_headerwere three overlapping derivations).rate_micro_per_ns→rate_per_sec— the field stores raw tokens-per-second, not microtokens-per-nanosecond. Updated doc comments to match.Test plan
cargo clippy -- -D warningsclean