🧪 [testing improvement description]#1223
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🔒 Release Safety Check Results✅ Safety Checks Passed {"code":"NOT_FOUND","message":"Requested function was not found"} |
🔍 Classification Check Results
✅ No violations detected. Safe to merge! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a979be3600
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| expect(mockQueueInstance.add).toHaveBeenCalledWith( | ||
| "job", | ||
| data, | ||
| expect.objectContaining({ priority: 50 }) |
There was a problem hiding this comment.
For non-enterprise jobs, this expectation locks in priority: 50 for a PRO/HIGH job, but BullMQ v5 processes lower numeric priority values first (official docs: https://docs.bullmq.io/guide/jobs/prioritized). In the inspected implementation, FREE/LOW gets 1 while PRO/HIGH gets 50, so this new test codifies the inversion and will keep higher-tier urgent jobs behind lower-tier jobs once real BullMQ ordering is exercised.
Useful? React with 👍 / 👎.
🔒 Release Safety Check Results✅ Safety Checks Passed {"code":"NOT_FOUND","message":"Requested function was not found"} |
🔍 Classification Check Results
✅ No violations detected. Safe to merge! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbae2c65c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "outDir": "dist", | ||
| "rootDir": "src" | ||
| }, | ||
| "references": [{ "path": "../logger" }], |
There was a problem hiding this comment.
With this project reference in place, the package-local script pnpm --filter @settler/agents run typecheck now fails on a clean checkout when packages/logger/dist has not already been emitted: TypeScript reports TS6305 for packages/logger/dist/index.d.ts from src/security-agent.ts. The package still runs plain tsc --noEmit, so it does not build referenced projects itself; either the agents script needs to use build mode / a prebuild step, or this reference should not require prebuilt logger outputs.
Useful? React with 👍 / 👎.
|
Closed during PR cleanup: mergeable=UNKNOWN base=main. Reopen only with a current verified change. |
1 participant
🎯 What: Added tests for PrioritizedQueue class to cover missing queue and priority logic.
📊 Coverage: Covered constructor, job addition, startWorker, getStats, and lifecycle methods, checking priority calculation based on TenantTier.
✨ Result: Improved reliability in queue system and priority calculation logic.
PR created automatically by Jules for task 3369590038567870017 started by @Hardonian