⚡ Parallelize embedding operations in ingestRecords#191
Conversation
Signed-off-by: Jules <jules@example.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
This repository limits contributors to 10 open pull requests. Please close or merge existing PRs before opening new ones. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7b9a01c64b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const rows = []; | ||
| for (const record of input.records) { | ||
|
|
||
| const rows = await Promise.all(input.records.map(async (record) => { |
There was a problem hiding this comment.
Bound embedding fan-out during ingestion
When ingestRecords receives a large batch and the adapter calls a real embedding runtime, this Promise.all(input.records.map(...)) starts one embedding request per record immediately. That removes the previous backpressure from sequential awaits and can exhaust provider rate limits, sockets, or local GPU memory before upsert is reached; use a bounded concurrency/batching strategy so ingestion still parallelizes without unbounded fan-out.
Useful? React with 👍 / 👎.
💡 What: Replaced the sequential
forloop iningestRecordswith aPromise.all(input.records.map(...))implementation to execute the embedding operations concurrently.🎯 Why: Previously, the
ingestRecordsfunction would sequentiallyawaitthe embedding generation for each record. By utilizingPromise.all, we parallelize the network/computation requests, reducing overall ingestion latency significantly when processing multiple records.📊 Measured Improvement:
Signed-off-by: Jules jules@example.com
PR created automatically by Jules for task 8272458846080741025 started by @Hardonian