🧹 fix: 🛡️ Sentinel: [code health] enforce landlock mode#189
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
This repository limits contributors to 10 open pull requests. Please close or merge existing PRs before opening new ones. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4202d1f953
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # across different kernel versions before we flip this. (ref #516 item 3) | ||
| landlock: | ||
| compatibility: best_effort | ||
| compatibility: strict |
There was a problem hiding this comment.
Add preflight handling before enabling strict Landlock
In environments where the Docker VM or Linux host kernel lacks Landlock support (for example <5.13 or Landlock disabled), switching the base policy to compatibility: strict makes sandbox creation fail closed, but the onboarding code only checks kernel support after the sandbox has already been created and still tells users restrictions will degrade in best-effort mode (src/lib/onboard.ts). This turns a previously supported/degraded onboarding path into an opaque create-time failure unless the preflight/docs/error path are updated to make Landlock a hard prerequisite before this policy is applied.
Useful? React with 👍 / 👎.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (1 files)
Reviewed by laguna-m.1-20260312:free · 1,115,183 tokens |
🎯 What: Evaluated and enabled strict landlock enforcement mode in the openclaw-sandbox.yaml base policy.
💡 Why: Switching from best_effort to strict enforcing secures the sandbox by failing closed rather than silently ignoring landlock enforcement failures.
✅ Verification: Verified testing suite passes cleanly with npm run verify:core.
✨ Result: A more secure and predictable default sandbox environment configuration.
PR created automatically by Jules for task 6561170165977134394 started by @Hardonian