security: fix decoy root manifest — 92 phantom vulns → 3 real (0 critical)#218
Merged
Conversation
…eal) Root package.json declared next@^9.3.3 with a stale package-lock.json that Dependabot scanned (92 phantom vulns). The actual Next.js app lives in ./site (next@16, react@19) and is what builds/deploys. - Removed decoy next@9 dep from root package.json - Deleted stale root package-lock.json (next@9 tree) - Bumped site/: next@latest, postcss@latest, brace-expansion@latest Result: real app has 3 vulns (0 critical, 0 high) — was falsely reporting 92 from the unused root lockfile. Site builds clean (next build exit 0, 16 static routes).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| "react-dom": "19.2.7" | ||
| } | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
SUGGESTION: Missing trailing newline at end of file
POSIX text files should end with a newline character. The absence of a trailing newline can cause issues with some linters, formatters, and text-processing tools.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Reviewed by step-3.7-flash · Input: 284.5K · Output: 10.5K · Cached: 500.7K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix (decoy manifest correction)
Root cause
The root
package.jsondeclarednext@^9.3.3with a stalepackage-lock.jsonthat Dependabot scanned, reporting 92 vulnerabilities (1 critical, 25 high). This was a phantom — the root manifest is NOT what builds. The actual Next.js app is in./site/(next@16.2.6, react@19.1.0) and is the target ofvercel.json+ CI (working-directory: site).Changes
next@9dependency from rootpackage.json.package-lock.json(next@9 tree).site/:next@latest,postcss@latest,brace-expansion@latest.Result
next buildpasses (exit 0, 16 static routes prerendered).Verification
cd site && npm run build→ exit 0.npm auditinsite/→ 3 vulnerabilities../sitecorrectly going forward.Auto-merge enabled; merges when CI green.