Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes a set of small improvements across flycomp integration, tab-completion process behavior, and a few UX/demo tweaks. It extends Flyline’s ability to persist synthesized completion scripts, improves error display for flycomp failures, and updates some underlying integration details.
Changes:
- Add a configurable
flycomp_outputsetting/CLI flag and write synthesized completion scripts to disk on success. - Improve flycomp error rendering (multi-line) and adjust shell-script evaluation flags; add basename fallback when detecting registered compspecs.
- Minor UX/maintenance tweaks: tab-completion child signal/session setup, mouse pointer-shape rename, demo tape timing updates, and bump
flycompgit revision.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tapes/demo_overview.tape |
Slows typing speed to improve demo readability/stability. |
tapes/demo_auto_tab_completion.tape |
Slows typing speed to improve demo readability/stability. |
src/settings.rs |
Adds flycomp_output: Option<String> to persist a configurable output directory. |
src/mouse_state.rs |
Renames/adjusts pointer shape used for hoverable/clickable UI elements. |
src/cli.rs |
Adds --flycomp-output to configure where synthesized completions are written. |
src/bash_symbols.rs |
Adds SEVAL flag constants used when evaluating synthesized scripts. |
src/bash_funcs.rs |
Adds basename compspec lookup fallback; evaluates scripts with flags; writes completion scripts to disk; adds tests. |
src/app/ui.rs |
Improves flycomp error output formatting by rendering multi-line errors cleanly. |
src/app/tab_completion.rs |
Adjusts child-process session and signal handling for tab-completion fork path. |
src/app/mod.rs |
Writes synthesized completion scripts to disk and improves error chaining for flycomp failures. |
src/app/actions.rs |
Reorders default keybinding entries (no functional change intended). |
Cargo.toml |
Bumps flycomp git revision. |
Cargo.lock |
Updates lockfile for the bumped flycomp revision. |
Comment on lines
1406
to
+1409
| let thread_handle = std::thread::spawn(move || { | ||
| unsafe { | ||
| libc::signal(libc::SIGCHLD, libc::SIG_DFL); | ||
| } |
HalFrgrd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a configurable flycomp_output setting/CLI flag and write synthesized completion scripts to disk on success.
Improve flycomp error rendering (multi-line) and adjust shell-script evaluation flags; add basename fallback when detecting registered compspecs.
Minor UX/maintenance tweaks: tab-completion child signal/session setup, mouse pointer-shape rename, demo tape timing updates, and bump flycomp git revision.