ITP-2026-1 | Nikita Sharma | Week-2 | Form Control

[nikki08-09]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Added fieldsets and labels to give each section a separator group.
Added radio button to colours and sizes to select their choices.

[talmurshidi]

@nikki08-09 ,Good progress --- this is a solid submission with clear semantic grouping. You are very close. A few fixes are still needed to align exactly with the assignment and keep the PR clean.

What You Did Well

• Good use of fieldset and legend to group related controls.
• Name validation is correct with minlength="2" and required.
• Labels are properly associated with inputs.
• Colour choices are limited to 3 valid options.

Fix / Improve

1. Size control does not follow the teacher guidance

Your size input is implemented as a radio group. It works, but for this assignment the preferred solution is:

• radio for colours
• select for sizes

So you should change the size section to a <select> with these 6 options:

<fieldset>
  <legend for="size">Size</legend>
  <select id="size" name="size" required>
    <option value="" disabled selected>Select a size</option>
    <option value="xs">XS</option>
    <option value="s">S</option>
    <option value="m">M</option>
    <option value="l">L</option>
    <option value="xl">XL</option>
    <option value="xxl">XXL</option>
  </select>
</fieldset>

2. Remove unnecessary <br /> tags

You used <br /> after labels in the name and email fields. Avoid using <br> for layout. Keep structure clean with <div> grouping only.

Example:

<div>
  <label for="name">Full Name</label>
  <input type="text" id="name" name="name" minlength="2" required />
</div>

3. Duplicate viewport meta tag

You have two viewport meta tags:

<meta name="viewport" content="width=device-width, initial-scale=1.0" />\
<meta name="viewport" content="width=device-width, initial-scale=1" />

Keep only one.

4. Validate your HTML

Before final submission, validate the markup:

https://validator.w3.org/#validate_by_input

Check for:

• duplicate meta tags

• any structural issues

• unnecessary markup

Then revalidate until you get 0 errors.

Unrelated files in PR

You added:

• Wireframe/Forms.html

This is not part of the assignment and should be removed from the PR.

If it is a new file added only in this branch:

git rm Wireframe/Forms.html
git commit -m "Remove unrelated wireframe file"
git push

The PR will update automatically.

Commits feedback

Your commits show progress, but they can be improved.

Current:

• Added forms.html
• Added fieldsets and legends for each section
• Added fieldsets and labels
• Added div and minlength-2

Issues:

• repetitive
• not very precise
• one commit references an unrelated file

Better examples:

• Add form structure
• Add fieldsets and legends
• Add labels and validation
• Refactor form groups with divs

Summary

This submission is close, but revise these points:

• change size to a select

• remove <br /> used for layout

• remove the duplicate viewport meta tag

• change footer heading to a paragraph

• remove the unrelated wireframe file from the PR

After that, this should be in good shape.

[nikki08-09]

@talmurshidi I have implemented your suggestions. Please review again.