Skip to content

Brussels | ITP-1-2026 | Nikita Sharma | Sprint-1#141

Open
nikki08-09 wants to merge 21 commits into
HackYourFutureBelgium:mainfrom
nikki08-09:Sprint-1
Open

Brussels | ITP-1-2026 | Nikita Sharma | Sprint-1#141
nikki08-09 wants to merge 21 commits into
HackYourFutureBelgium:mainfrom
nikki08-09:Sprint-1

Conversation

@nikki08-09
Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

fix the code.
Added tests to implement the code.
Added refactoring to do the code with other way.

Copy link
Copy Markdown

@jamesishimwe jamesishimwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works as expected and all the tasks are completed. The code is easy to understand and the variable and function names are well defined,clear and meaningful. The code is well structured and well formatted.

@nuttyproducer
Copy link
Copy Markdown

Well done Nikita! Your implementations are clear and easy to read, and the logic for sum, max, dedupe, and the includes refactor looks correct. The tests also cover the expected cases nicely.

What was implemented well:

dedupe.js is implemented correctly and clearly.
sum.js correctly sums only numeric values.
max.js correctly filters numeric values and returns -Infinity when appropriate.
includes.js was successfully refactored to use for...of.
The added tests for sum, max, and dedupe generally match the intended behavior.

Logic / syntax check

Looks correct
No obvious syntax errors in the changed files.
Logic is generally clear and readable.
Function names and implementation style are beginner-friendly and easy to understand.

Small issues to mention
median.js has a debug console.log

Comment thread Sprint-1/fix/median.js
}
}

console.log(calculateMedian([1, "apple", 2, 3, 4])); // Output: 2.5
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

median.js has a debug console.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants