fix(skill_engine): preserve multiline frontmatter values#106
Open
santhreal wants to merge 2 commits into
Open
Conversation
set_frontmatter_field wrote raw newlines into YAML, so parse_frontmatter kept only the first line. Quote multiline scalars and drop old block continuation lines when replacing a field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
set_frontmatter_fieldwrote raw newlines into YAML, soparse_frontmatterkept only the first line. Replacing a|block also left orphan indented lines.Repro
Fix
Quote multiline scalars with escaped
\n, unescape them in the no-PyYAML fallback, and drop old block continuation lines when replacing a field.