fix(skill_engine): keep SKILL.md when *** File: appears in prose#105
Open
santhreal wants to merge 2 commits into
Open
fix(skill_engine): keep SKILL.md when *** File: appears in prose#105santhreal wants to merge 2 commits into
santhreal wants to merge 2 commits into
Conversation
A single mid-document *** File: marker was treated as multi-file FULL output, so create_skill wrote only the spurious file and dropped SKILL.md. Match the detect_patch_type docstring: require two markers or one at the start with a body, and keep whole-content SKILL.md for mid-doc singles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A skill body that mentions a single mid-document
*** File:line (for example inside an example) was parsed as multi-file FULL output.create_skillthen wrote only that file and never createdSKILL.md.Repro
Fix
Align
detect_patch_typewith its docstring (≥2 markers, or one at content start with a body). For a single mid-document*** File:,parse_multi_file_fullkeeps the whole content asSKILL.md.