Skip to content

fix(path_utils): anchor is_safe_path containment on a separator boundary #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Osamaali313 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(path_utils): anchor is_safe_path containment on a separator boundary #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions fastcode/path_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,14 @@ def is_safe_path(self, path: str) -> bool:
if resolved is None:
# Also check if the joined path would be safe (even if doesn't exist yet)
abs_path = os.path.abspath(os.path.join(self.repo_root, path))
return abs_path.startswith(self.repo_root)
return resolved.startswith(self.repo_root)
else:
abs_path = resolved
# Require an exact match or a path-separator boundary, so a sibling
# directory that merely shares the repo-root name prefix (e.g.
# "myrepo_secrets" vs "myrepo") or a "../" escape onto it is not
# treated as inside the repository.
return (abs_path == self.repo_root
or abs_path.startswith(self.repo_root + os.sep))
except Exception as e:
self.logger.warning(f"Path security check failed for {path}: {e}")
return False
Expand Down