fix: prevent shell command injection in verification endpoint#5
Open
haosenwang1018 wants to merge 1 commit into
Open
fix: prevent shell command injection in verification endpoint#5haosenwang1018 wants to merge 1 commit into
haosenwang1018 wants to merge 1 commit into
Conversation
Use shlex.split() with shell=False instead of shell=True when executing the verification command from API payload. This prevents shell metacharacter injection (e.g. `; rm -rf /`) via the command_success field. Fixes HKUDS#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The verification command in the execute endpoint uses
shell=Truewith user-controlled input (verification['command_success']), which allows arbitrary command injection via shell metacharacters.For example, a malicious payload like
"ls; rm -rf /"would be interpreted by the shell.Fix
Replace
shell=Truewithshell=Falseand useshlex.split()to safely tokenize the command string into a list. This prevents shell interpretation of metacharacters while preserving normal command execution.shlexwas already imported in the file.Fixes #4