[Issue #11811] Stop s3 logging GetApplicationZip response - #11813
Merged
jakobpederson merged 2 commits intoAug 5, 2026
Merged
Conversation
1 task
jakobpederson
requested review from
chouinar,
freddieyebra,
hao10282025-sudo,
kkrug and
mdragon
August 3, 2026 19:19
jakobpederson
marked this pull request as ready for review
August 3, 2026 19:19
chouinar
reviewed
Aug 3, 2026
Comment on lines
+594
to
+598
| file_util.write_to_file( | ||
| response_s3_path, | ||
| "GetApplicationZip response not currently logged", | ||
| content_type=text_content_type, | ||
| ) |
Collaborator
There was a problem hiding this comment.
Why write static content to the file? Should we just log instead?
Collaborator
Author
There was a problem hiding this comment.
In a discussion it came down to the static content or the log, I think I just chose the wrong one. I'll update it.
chouinar
approved these changes
Aug 5, 2026
jakobpederson
deleted the
jakobpederson/11811-stop-s3-logging-get-application-zip-response
branch
August 5, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes / Work for #11811
Changes proposed
GetApplicationZipRequestin thewrite_debug_to_s3method and if it's true to just put a placeholder message instead of trying to write the responseContext for reviewers
Currently the attempt to write to s3 is throwing an
UnicodeDecodeErrorwhen trying to write the response to s3:So we're currently going to skip on writing it to s3.
Validation steps
once deployed