Skip to content

[Issue #10419] Add validation to award recommendation submission edit page - #11812

Merged
nathan-stricker merged 2 commits into
mainfrom
nathan-stricker/10419-add-error-validation-to-edit-award-rec-submission-page
Aug 5, 2026
Merged

[Issue #10419] Add validation to award recommendation submission edit page#11812
nathan-stricker merged 2 commits into
mainfrom
nathan-stricker/10419-add-error-validation-to-edit-award-rec-submission-page

Conversation

@nathan-stricker

Copy link
Copy Markdown
Collaborator

Summary

Work for #10419

Changes proposed

  • Add required-field validation on the award recommendation submission edit form (single and bulk), with a top USWDS alert and per-field error messages for Recommendation, Reason for exception (when the exception checkbox is checked), and Amount recommended
  • Replace native select required with a “Select one” placeholder and custom validation
  • Strip non-numeric characters from Amount recommended while typing (same approach as budget amount inputs), via new sanitizeCurrencyInput helper

Context for reviewers

Validation lives in RecommendationDetailForm and is wired through RecommendationSubmissionEditForm (single) and EditRecommendationsForm (bulk). Amount recommended is still formatted as currency on blur; sanitization only restricts input while typing.

Validation steps

  • Submit single and bulk edit with Recommendation, exception reason (when checked), and/or Amount recommended empty
    • validate presence of top alert + field errors block submit
  • Fill required fields
    • validate that submit succeeds
  • Type letters in Amount recommended
    • validate that non-numeric characters are rejected; blur still formats currency

@nathan-stricker
nathan-stricker marked this pull request as ready for review August 3, 2026 19:02

@chay-REIsys chay-REIsys left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@nathan-stricker
nathan-stricker merged commit 96378e2 into main Aug 5, 2026
14 checks passed
@nathan-stricker
nathan-stricker deleted the nathan-stricker/10419-add-error-validation-to-edit-award-rec-submission-page branch August 5, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants