fix(DuplicateGlobals): skip unnamed globals and guard against the type mismatch.#23
Open
osmandagli wants to merge 17 commits into
Open
fix(DuplicateGlobals): skip unnamed globals and guard against the type mismatch.#23osmandagli wants to merge 17 commits into
osmandagli wants to merge 17 commits into
Conversation
Some other features shall be implemented and fixes done for these tests to pass
- Now the entrypoint of the program (usually the "main" function) is duplicated in-place when using EDDI, so that the program directly enters the Sphere of Replication - Avoided the search for debug locations when debug is not enabled
… different consistency check - Now in EDDI we can generate an ErrBB block for each consistency check which, after the call to "DataCorruption_Handler()", jumps to the normal continuation basic block - CFCSS has been fixed to support multiple ErrBB
Added basic case and more checks to avoid null dereferences
Now indirect function calls are hardened by calling the duplicate version of the function, passing both the original and the duplicate operands. Also, a consistency check on the pointer of the function to be called is added too (in addition to the classic consistency checks of the operands).
…cated variable names and type mistach
8532b5a to
a1987cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
Fix the duplicated global variable names and type mismatch.
PR Description
The original loop in the DuplicateGlobals.cpp file does not control the variable names, and this causes all the unnamed (compiler-generated) variables (e.g., '@3 = internal global i64 0', '@4 = internal global i8 0') to become '@_dup'. This causes a type mismatch error, since the second variable will try to initialize, but the variable type is different than the first one.
Solution
Summary
Added the necessary checks for all the empty named variables and type mismatches to prevent type mismatch errors.