feat(round-robin): break points ties by fastest single lap#321
Merged
Conversation
A round-robin tie on points now resolves to the pilot with the faster fastest single lap (competitor ref remains the last-resort tiebreak). To make this win-condition-independent, Placement gains best_lap_micros (the fastest counted lap in a heat, computed for every win condition — FirstToLaps, Timed, etc. — not just best-lap rounds); round_robin::ranking tracks each pilot's min across heats and breaks score ties by it (a no-lap pilot sorts behind one with a lap). cargo xtask ci green (no binding drift; Placement.ts gains best_lap_micros: number|null); frontend check 0 errors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ype-check) The new Placement.best_lap_micros field made the components tests/fixtures.ts HeatResult literals incomplete — CI's fresh @gridfpv/types build flagged 3 type errors (local check passed only because the types dist was stale). Add the field to the fixture's three placements. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A round-robin points tie now resolves to the pilot with the faster fastest single lap (ref stays the last resort).
Placementgainsbest_lap_micros(fastest counted lap, computed for every win condition) so the tiebreak works for FirstToLaps round-robins too;round_robin::rankingbreaks score ties by each pilot's min-across-heats (no-lap sorts last).cargo xtask cigreen (no binding drift); frontend check 0 errors.🤖 Generated with Claude Code