Constrain tar driver paths to image root#555
Open
fsabiu wants to merge 1 commit intoGoogleContainerTools:mainfrom
Open
Constrain tar driver paths to image root#555fsabiu wants to merge 1 commit intoGoogleContainerTools:mainfrom
fsabiu wants to merge 1 commit intoGoogleContainerTools:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a secure path resolution utility, ResolvePathInRoot, designed to prevent path traversal and ensure all file operations remain within a specified root directory. This utility is integrated into the tar unpacking logic and the TarDriver to safely handle symlinks and hard links. A review comment identifies a bug in hard link creation where symlinks are incorrectly followed; it is recommended to set followFinalSymlink to false for tar.TypeLink entries to ensure the link points to the entry itself rather than its target.
693053b to
2abf6c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds root-confined path resolution for tar-backed image filesystem paths.
It treats absolute image paths as absolute inside the extracted image root, resolves symlink targets using image-root semantics, rejects traversal above that root, and applies the helper to tar extraction plus tar-driver
StatFile,ReadFile, andReadDir.Tests added cover:
Local validation:
go test ./internal/pkgutil ./pkg/drivers -count=1