feat: Add a go plugin to add geo query string to URL - #295
feat: Add a go plugin to add geo query string to URL#295mateustd-ciandt wants to merge 13 commits into
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
See comment #289 (comment) , the plugin should access geo information via the GetProperty() API, in anticipation of attribute support for geo info to be added in Q1. |
mpwarres
left a comment
mpwarres
left a comment
There was a problem hiding this comment.
LGTM mod comment. Thanks!
| } | ||
|
|
||
| func (ctx *httpContext) addCountryParameter(path, countryValue string) string { | ||
| var builder strings.Builder |
There was a problem hiding this comment.
Suggest using the Go net/url package for query param manipulation, as is already done in a number of other Go examples: https://github.com/search?q=repo%3AGoogleCloudPlatform%2Fservice-extensions+net%2Furl&type=code
There was a problem hiding this comment.
Done! Thanks!
2 participants
Adding a new GO plugin in order to modulate content based on the country value.
This value is added as a query string name value pair in the URL.
The query string value is also available in the normal GCP logs.
C++ version PR: #289
Rust version PR: #294