Skip to content

Add exadataInfrastructure field and sample to ExascaleDbStorageVault#18136

Open
virgulati2003 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
virgulati2003:feature/oracledatabase-storage-vault-exadata
Open

Add exadataInfrastructure field and sample to ExascaleDbStorageVault#18136
virgulati2003 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
virgulati2003:feature/oracledatabase-storage-vault-exadata

Conversation

@virgulati2003

@virgulati2003 virgulati2003 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Description

This PR adds support for linking a google_oracle_database_exascale_db_storage_vault resource to a dedicated Oracle Cloud Exadata Infrastructure via the new exadata_infrastructure field.

This maps to the exadataInfrastructure parameter on the Oracle Database exascaleDbStorageVaults API endpoint.

Additionally, this PR:

  1. Adds a dedicated test sample oracledatabase_exascale_db_storage_vault_dedicated_exadata_infrastructure verifying creation, import, and teardown lifecycles.
  2. Increases the test vault size to 2048 GB (total_size_gbs = 2048) to meet the minimum size requirement for dedicated Exadata instances.
  3. Exposes the top-level timeouts configuration block in the resource schema to allow HCL timeout overrides.

Fixes hashicorp/terraform-provider-google#28171

Release Note

oracledatabase: added `exadata_infrastructure` field to `google_oracle_database_exascale_db_storage_vault` resource

@github-actions github-actions Bot requested a review from slevenick June 30, 2026 08:18
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d757283:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 170 insertions(+), 8 deletions(-)
google-beta provider View Diff 4 files changed, 170 insertions(+), 8 deletions(-)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 139 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
47 44 2 1
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccOracleDatabaseExascaleDbStorageVault_oracledatabaseExascaleDbStorageVaultDedicatedExadataInfrastructureExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccOracleDatabaseExascaleDbStorageVault_oracledatabaseExascaleDbStorageVaultDedicatedExadataInfrastructureExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@virgulati2003, @slevenick VCR tests complete for d757283!

@virgulati2003 virgulati2003 force-pushed the feature/oracledatabase-storage-vault-exadata branch from d757283 to 307207b Compare June 30, 2026 08:40
@modular-magician

modular-magician commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 307207b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 174 insertions(+), 8 deletions(-)
google-beta provider View Diff 4 files changed, 174 insertions(+), 8 deletions(-)
terraform-google-conversion View Diff 1 file changed, 10 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 141 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
47 44 2 1
Affected Service Packages
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccOracleDatabaseExascaleDbStorageVault_oracledatabaseExascaleDbStorageVaultDedicatedExadataInfrastructureExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccOracleDatabaseExascaleDbStorageVault_oracledatabaseExascaleDbStorageVaultDedicatedExadataInfrastructureExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@virgulati2003, @slevenick VCR tests complete for 307207b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support dedicated Exadata Infrastructure in google_oracle_database_exascale_db_storage_vault

2 participants