fix: Defer endpoint release while requests are in flight#693
Open
nyan-left wants to merge 2 commits intoGoogleChromeLabs:mainfrom
Open
fix: Defer endpoint release while requests are in flight#693nyan-left wants to merge 2 commits intoGoogleChromeLabs:mainfrom
nyan-left wants to merge 2 commits intoGoogleChromeLabs:mainfrom
Conversation
nyan-left
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #692
FinalizationRegistrycleanup currently closes the endpoint and clearspendingListenerswithout checking whether any are mid-flight, so a GC'd proxy during a long await silently drops the worker's reply and the awaiter hangs forever.This patch defers the release while
pendingListeners.size > 0and runs it from the message handler once they drain. No public API change.Includes a karma test that fails in 2s when
src/comlink.tsis reverted, passes with the change applied. Self-skips when--js-flags=--expose-gcisn't available.