Generating symbolic link for the theme itself#22
Open
felipenmoura wants to merge 1 commit into
Open
Conversation
Now, you can clone the project straight into your `/wp-content/themes`. Once you build it, it will create a _symbolic link_ to the theme directory in your project in the parent's directory. With this, users will be able to see the _PWAWP-theme_ as one of the themes in their WP admin. For the deploy, we should copy the dist diretory and the symbolic link. I believe we can make it better, though.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Author
|
I've just signed in for the CLA agreement. |
|
CLAs look good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, you can clone the project straight into your
/wp-content/themes.Once you build it, it will create a symbolic link to the theme directory in your project in the parent's directory. With this, users will be able to see the PWAWP-theme as one of the themes in their WP admin.
The interesting thing here is that now, we can run
npm run watchonce, and as we save files in our theme, the changes will be applied to our local wordpress page (no need to copy the theme into wp-content dir again and again).For the deploy, we should copy the dist diretory and the symbolic link. I believe we can make it better, though.