Skip to content

Generating symbolic link for the theme itself#22

Open
felipenmoura wants to merge 1 commit into
GoogleChromeLabs:masterfrom
felipenmoura:master
Open

Generating symbolic link for the theme itself#22
felipenmoura wants to merge 1 commit into
GoogleChromeLabs:masterfrom
felipenmoura:master

Conversation

@felipenmoura

Copy link
Copy Markdown

This is a "proof of concept". I don't really expect it to be merged, but wanted to offer an insight so you could test it and validate its importance. Then, let's think together how we can make it work in a best way. You can check the diffs here to understand the idea.

Now, you can clone the project straight into your /wp-content/themes.
Once you build it, it will create a symbolic link to the theme directory in your project in the parent's directory. With this, users will be able to see the PWAWP-theme as one of the themes in their WP admin.

The interesting thing here is that now, we can run npm run watch once, and as we save files in our theme, the changes will be applied to our local wordpress page (no need to copy the theme into wp-content dir again and again).

For the deploy, we should copy the dist diretory and the symbolic link. I believe we can make it better, though.

Now, you can clone the project straight into your `/wp-content/themes`.
Once you build it, it will create a _symbolic link_ to the theme directory in your project in the parent's directory. With this, users will be able to see the _PWAWP-theme_ as one of the themes in their WP admin.

For the deploy, we should copy the dist diretory and the symbolic link. I believe we can make it better, though.
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@felipenmoura

Copy link
Copy Markdown
Author

I've just signed in for the CLA agreement.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants