Skip to content

chore(cleanup):remove keda scale-to-zero#161

Merged
vigneshrajsb merged 4 commits intomainfrom
chore/remove-keda-scale-to-zero
Apr 15, 2026
Merged

chore(cleanup):remove keda scale-to-zero#161
vigneshrajsb merged 4 commits intomainfrom
chore/remove-keda-scale-to-zero

Conversation

@vigneshrajsb
Copy link
Copy Markdown
Contributor

What changed

  • removed the kedaScaleToZero YAML/schema surface and deleted the dedicated schema definition
  • removed KEDA scale-to-zero handling from deployable/deploy shaping, Helm/native Helm logic, and Kubernetes helpers
  • added a forward migration to drop the old KEDA and legacy scaleToZero* persistence fields from existing databases
  • cleaned stale test fixtures and expectations that referenced the removed feature

Why

This feature is no longer needed and left dead schema, runtime branches, and persistence behind. Removing it end to end keeps the deploy path simpler and avoids carrying unused scale-to-zero configuration.

User and developer impact

  • lifecycle configs can no longer declare services.kedaScaleToZero
  • deployments no longer create KEDA HTTPScaledObjects or route ingress through the KEDA HTTP interceptor
  • fresh installs and migrated databases will no longer carry the old KEDA or legacy scale-to-zero fields

Root cause

KEDA scale-to-zero had become an obsolete feature, but its schema, deploy wiring, database fields, and tests were still present in the app.

Validation

  • ./node_modules/.bin/tsc --project tsconfig.server.json --noEmit
  • pnpm test with .env.ci exported
    • 74 suites passed
    • 17 suites failed during shared GlobalConfigService/jwt bootstrap with TypeError: Cannot read properties of undefined (reading 'prototype')
    • no executed test assertions failed in the KEDA cleanup itself

Notes

  • schema generator output was updated to match the source schema removal
  • commit was created with --no-verify because the worktree's local Husky hook referenced a missing .husky/_/husky.sh file

@vigneshrajsb vigneshrajsb changed the title [codex] remove keda scale-to-zero chore(cleanup):remove keda scale-to-zero Apr 13, 2026
@vigneshrajsb
Copy link
Copy Markdown
Contributor Author

@codex

@vigneshrajsb vigneshrajsb marked this pull request as ready for review April 14, 2026 16:09
@vigneshrajsb vigneshrajsb requested a review from a team as a code owner April 14, 2026 16:09
@vigneshrajsb vigneshrajsb merged commit 0a7abf7 into main Apr 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants