Hotfix: Fix client create

[chrismaddalena]

CHANGELOG

[6.3.6] - 26 May 2026

Fixed

• Fixed creating a new client with an incomplete point of contact causing a server error instead of displaying required-field validation errors (Fixes [Bug] Submitting a Client Contact without Mandatory Attributes Causes 500 Error #889)**

[Copilot]

Pull request overview

Fixes a server error (500) when submitting the ClientCreate form with an incomplete “Point of Contact” formset by ensuring the CreateView’s self.object is initialized, allowing the invalid form re-render path to build context correctly.

Changes:

• Initialize self.object = None in ClientCreate.get() and ClientCreate.post() to prevent AttributeError during form_invalid().
• Add a regression test that posts an incomplete PoC formset and asserts required-field errors are rendered (HTTP 200) and no client is created.
• Bump version metadata to 6.3.6 and add a changelog entry for the fix.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
VERSION	Bumps release version/date to 6.3.6 / 26 May 2026.
config/settings/base.py	Updates __version__ and RELEASE_DATE constants.
CHANGELOG.md	Documents the hotfix under 6.3.6 (Fixes #889).
ghostwriter/rolodex/views.py	Prevents 500 on invalid create by setting self.object = None in GET/POST.
ghostwriter/rolodex/tests/test_views.py	Adds regression coverage for incomplete PoC submission during client creation.

[augmentcode]

🤖 Augment PR Summary

Summary: Hotfixes client creation when an incomplete Point of Contact (PoC) submission would previously trigger a server error.

Changes:

• Initialize self.object = None in ClientCreate.get() and ClientCreate.post() so invalid submissions re-render properly.
• Add a regression test ensuring an invalid PoC formset returns 200 with required-field errors and does not create the client.
• Bump release metadata to 6.3.6 (CHANGELOG, VERSION, settings).

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

[codecov]

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 93.32%. Comparing base (a23087b) to head (7794c3c).

Files with missing lines	Patch %	Lines
ghostwriter/rolodex/views.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   93.20%   93.32%   +0.12%     
==========================================
  Files         393      393              
  Lines       25046    25063      +17     
==========================================
+ Hits        23344    23391      +47     
+ Misses       1702     1672      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.