Align subscriptions dates during sync

[ivanb777]

TODO
See Asana issue

[ivanb777]

@michael-gratton hei... does this align with what you had in mind? would be good to chat when you get a chance...

[michael-gratton]

@ivanb777 hey apologies, I won't have time to review this properly either. Am a little bit surprised the state is being determined outside the sync call without carrying forward any state determined there (sub status, sync type & direction) - surely that context is needed, but haven't had time to sit down and look at it properly.

[ivanb777]

hei @michael-gratton

the state is being determined outside the sync call

not sure what you mean – we are performing this within the sync call, but only when we're creating/updating a member in Id.

without carrying forward any state determined there (sub status, sync type & direction) - surely that context is needed

With exception of using it for logging, I cannot see why we would need the sync context here. We are attempting to align the timestamps to when the member joined, and when subs-related events occurred. For that purpose I cannot see why sub status, sync type & direction are relevant.

In my mind this is a retrospective process triggered only after all modifications on the member's record are completed. Yes, joined at can be completed earlier during payload preparation, which may be a question of preference, I just opted to handle them both as a distinct process.