Redact credentials from server.log#17
Open
average-enjoyer wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
average-enjoyer
force-pushed
the
redact-credentials-in-log
branch
from
July 20, 2026 09:18
d510196 to
efa8d43
Compare
Author
|
@googlebot I signed it! |
1 similar comment
Author
|
@googlebot I signed it! |
run_curl() logged the full curl command line to server.log before executing it, including the raw HTTP Basic Auth token from --user <username>:<auth_token> for the http_basic auth method, and the session cookie from -b <cookie> for the gitcookies auth method. Both end up sitting in plaintext in a log file on disk. Mask the credential-bearing arguments before writing the log line. The actual curl invocation is unchanged; only what gets logged is redacted.
average-enjoyer
force-pushed
the
redact-credentials-in-log
branch
from
July 20, 2026 09:32
efa8d43 to
ce36708
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
run_curl()inmain.pywrites the full curl command line toserver.logbefore executing it:[gerrit-mcp-server] Executing: curl --user :<auth_token> -L https://...
For the
http_basicauth method, this puts the raw HTTP Basic Auth token in plaintext in a log file on disk on every single request. Thegitcookiesauth method has the same problem — the session cookie passed via-b <cookie>ends up in the log the same way.Fix
Mask the credential-bearing arguments before writing the log line. The actual curl invocation is unchanged — only what gets written to
server.logis redacted.--user user:tokenbecomes--user user:***REDACTED***, and-b <cookie>becomes-b ***REDACTED***.Testing
Ran the server locally with
http_basicauth configured, made a real authenticated call against a Gerrit instanceget_change_details), and confirmed: - the request still succeeds (auth unaffected) -server.lognow shows--user <username>:***REDACTED***instead of the plaintext token