Skip to content

[Fixes #14136] Fixes the support for creation of dataset with generic Geometry type#14137

Merged
mattiagiupponi merged 2 commits intomasterfrom
ISSUE_14136
Apr 15, 2026
Merged

[Fixes #14136] Fixes the support for creation of dataset with generic Geometry type#14137
mattiagiupponi merged 2 commits intomasterfrom
ISSUE_14136

Conversation

@sijandh35
Copy link
Copy Markdown
Contributor

Fixes #14136

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Apr 14, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements support for generic 'Geometry' types within vector handlers and empty dataset utilities, mapping them to Django's GeometryField and GeoServer's JTS Geometry binding. It also updates the setup_dynamic_model method to support layer names provided as strings. A review comment suggests updating the type hint for the layer parameter in setup_dynamic_model to include str for better type safety and clarity.

Comment thread geonode/upload/handlers/common/vector.py
@mattiagiupponi mattiagiupponi merged commit 197bc3d into master Apr 15, 2026
16 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_14136 branch April 15, 2026 08:37
@github-actions
Copy link
Copy Markdown
Contributor

The backport to 5.0.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.0.x 5.0.x
# Navigate to the new working tree
cd .worktrees/backport-5.0.x
# Create a new branch
git switch --create backport-14137-to-5.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 197bc3d657be167c0b1d2fb75af2d7c9e9314c72
# Push it to GitHub
git push --set-upstream origin backport-14137-to-5.0.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.0.x

Then, create a pull request where the base branch is 5.0.x and the compare/head branch is backport-14137-to-5.0.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support the creation of datasets with generic Geometry type

3 participants