Skip to content

chore: bump gnus-ai submodule — Safe upgrade pipeline fixes + bridgeOut Sepolia deploy#3

Open
Super-Genius wants to merge 13 commits into
mainfrom
develop
Open

chore: bump gnus-ai submodule — Safe upgrade pipeline fixes + bridgeOut Sepolia deploy#3
Super-Genius wants to merge 13 commits into
mainfrom
develop

Conversation

@Super-Genius

Copy link
Copy Markdown
Contributor

Bumps gnus-ai submodule to include:

  • Safe upgrade pipeline fixes (gnus-ai PR #63)
  • GNUSBridge v2.5 bridgeOut deployed to Sepolia
  • yarn safe:upgrade orchestrator command

Super-Genius and others added 10 commits May 26, 2026 18:32
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Update gnus-ai submodule to include ROADMAP.md phases 8-12
- Add Update-Smart-Contracts-Architecture.md (architecture analysis)
- Update settings.local.json permissions for gsd-inbox/explore/discuss
gnus-ai: 761c373..886bdf5 (feature/bridge-out-initiated)
  feat(08.2): check:safe-executed + verify/confirm fixes
  docs(08.2): verification report (status pass)
  docs(08.2): ship bridge-out workstream

nested diamonds/GeniusDiamond develop: 6800205..7c4bb20 (3 commits)
  fix(deploy): reconcile sepolia deployment to live v2.5 + exec tx hash

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 765532c646

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread gnus-ai Outdated
@@ -1 +1 @@
Subproject commit 524aff08d5a3229f4114edf6b0d52e6645c8ad62
Subproject commit 17654d4c448b1512e9b9e4d4f93f2a1eb9b2d019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Forward --rpc-url to the confirmation step

The new gnus-ai submodule pin adds scripts/safe/safeUpgrade.ts, but step3Confirm invokes confirmDeployment.ts with only --artifact and --deployment, even though confirmDeployment.ts requires --rpc-url unless RPC_URL is set. In the supported case where an operator runs safe:upgrade with --rpc-url instead of an env var, proposing and waiting can succeed, then confirmation exits with “RPC URL required,” leaving the upgrade half-orchestrated and the deployed-data file unconfirmed.

Useful? React with 👍 / 👎.

Comment thread gnus-ai Outdated
@@ -1 +1 @@
Subproject commit 524aff08d5a3229f4114edf6b0d52e6645c8ad62
Subproject commit 17654d4c448b1512e9b9e4d4f93f2a1eb9b2d019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Derive the deployment filename from the target chain

The pinned gnus-ai revision adds an orchestrator that accepts --network, but both wait and confirm build the deployed-data path as geniusdiamond-${opts.network}-11155111.json. For any non-Sepolia network, this either fails to find the correct file or mutates a stale/Sepolia-named deployment record after a real Safe execution, so the orchestration can corrupt or miss the deployment state. Use the proposal artifact/RPC/config chain id instead of hard-coding 11155111.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant